Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added route_mode support for NLB vnf #3208

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

ujjwal-ibm
Copy link
Collaborator

@ujjwal-ibm ujjwal-ibm commented Oct 14, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestAccIBMISLB_basic_network_vnf
--- PASS: TestAccIBMISLB_basic_network_vnf (1510.79s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 1513.447s
=== RUN   TestAccIBMISLBDatasource_basic
--- PASS: TestAccIBMISLBDatasource_basic (433.70s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 436.315s
=== RUN   TestAccIBMISLBSDatasource_basic
--- PASS: TestAccIBMISLBSDatasource_basic (516.82s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 520.342s

Copy link
Collaborator

@hkantare hkantare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please share the testresults of all testcases for changed resources/datasources

ibm/resource_ibm_is_lb.go Outdated Show resolved Hide resolved
@hkantare hkantare merged commit ff612a2 into IBM-Cloud:master Oct 26, 2021
@ujjwal-ibm ujjwal-ibm deleted the nlb-vnf-route-mode branch December 1, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants