feat: implement the changes to enable/update the BFD config for the DirectLink gateways #3194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irectlink gateways * allow the user to add bfd_interval and bfd_multiplier for BFD configuration * show the status, interval, multiplier and bfd status updated at for Directlink Gateways
hkantare
reviewed
Oct 21, 2021
| }, | ||
| dlBfdStatusUpdatedAt: { | ||
| Type: schema.TypeString, | ||
| Computed: true, |
There was a problem hiding this comment.
can bfd_status_updated_at this be optional field
There was a problem hiding this comment.
BFD status updated at has been created as an optional field for ibm_dl_gateway resource at L123
| }, | ||
| dlBfdStatus: { | ||
| Type: schema.TypeString, | ||
| Computed: true, |
There was a problem hiding this comment.
status can be a optional field
There was a problem hiding this comment.
BFD status has been created as an optional field for ibm_dl_gateway resource at L117
| @@ -59,6 +59,8 @@ resource "ibm_dl_gateway" "test_dl_connect" { | |||
| Review the argument reference that you can specify for your resource. | |||
|
|
|||
| - `authentication_key` - (Optional, String) BGP MD5 authentication key. | |||
| - `bfd_interval` - (String) Minimum interval in milliseconds at which the local routing device transmits hello packets and then expects to receive a reply from a neighbor with which it has established a BFD session. | |||
| - `bfd_multiplier` - (String) The number of hello packets not received by a neighbor that causes the originating interface to be declared down. | |||
There was a problem hiding this comment.
The other two attributes bfd_status_updated_at and status one need to be added to attribute section
There was a problem hiding this comment.
added to attribute section here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Implement the following changes for Direct Link Gateways:
bfd_intervalandbfd_multiplierfor BFD configurationstatus,interval,multiplierandbfd statusupdated at for DirectLink GatewaysOutput from acceptance testing: