Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: gpu for instance profile datasource #3158

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

deepaksibm
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@deepaksibm
Copy link
Contributor Author

Do not merge. waiting for some api spec to be merged

@deepaksibm deepaksibm marked this pull request as draft October 19, 2021 11:45
@deepaksibm deepaksibm marked this pull request as ready for review October 28, 2021 10:04
@hkantare
Copy link
Collaborator

hkantare commented Nov 2, 2021

Please add test case results and also update all new attributes to docs

@deepaksibm
Copy link
Contributor Author

$ make testacc TEST=./ibm  TESTARGS='-run=TestAccIBMISInstanceProfilesDataSource_basic'
=== RUN   TestAccIBMISInstanceProfilesDataSource_basic
--- PASS: TestAccIBMISInstanceProfilesDataSource_basic (35.33s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 37.920s
$ make testacc TEST=./ibm  TESTARGS='-run=TestAccIBMISInstanceProfileDataSource_basic'
=== RUN   TestAccIBMISInstanceProfileDataSource_basic
--- PASS: TestAccIBMISInstanceProfileDataSource_basic (32.39s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 36.097s

@deepaksibm
Copy link
Contributor Author

Please add test case results and also update all new attributes to docs

Have added test case results and updated doc changes. let me know if a new test case has to be added. i didn't add a new case as it is a minor attribute addition

@hkantare hkantare merged commit 20b8865 into IBM-Cloud:master Nov 8, 2021
@deepaksibm deepaksibm deleted the feature-is-instance-gpu branch November 8, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants