Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update catalog offering instance resource and datasource #2745

Merged
merged 1 commit into from
Jun 17, 2021
Merged

update catalog offering instance resource and datasource #2745

merged 1 commit into from
Jun 17, 2021

Conversation

JonWoodlief
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccIBMCmOfferingInstance'
=== RUN   TestAccIBMCmOfferingInstanceDataSource
--- PASS: TestAccIBMCmOfferingInstanceDataSource (56.18s)
=== RUN   TestAccIBMCmOfferingInstance
--- PASS: TestAccIBMCmOfferingInstance (49.15s)
...

kavya498
kavya498 reviewed Jun 16, 2021
View reviewed changes
ibm/data_source_ibm_cm_offering_instance.go Show resolved Hide resolved
ibm/resource_ibm_cm_offering_instance.go Outdated Show resolved Hide resolved
ibm/resource_ibm_cm_offering_instance.go Show resolved Hide resolved
ibm/resource_ibm_cm_offering_instance.go Outdated Show resolved Hide resolved
website/docs/r/cm_offering_instance.html.markdown Outdated Show resolved Hide resolved
@JonWoodlief
Copy link
Contributor Author

@kavya498 thanks for the good feedback, I've pushed some changes

@hkantare hkantare merged commit 3aa905e into IBM-Cloud:master Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare left review comments

@kavya498 kavya498 kavya498 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JonWoodlief @hkantare @kavya498