Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Panics on Import #2585

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Fix: Panics on Import #2585

merged 1 commit into from
Jun 30, 2021

Conversation

kavya498
Copy link
Collaborator

@kavya498 kavya498 commented May 6, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

hkantare
hkantare reviewed May 7, 2021
View reviewed changes
ibm/resource_ibm_ob_logging.go Outdated
@@ -209,6 +210,9 @@ func resourceIBMLoggingRead(d *schema.ResourceData, meta interface{}) error {
if err != nil {
return err
}
if len(parts) < 2 {
return fmt.Errorf("Incorrect ID %s: Id should be a combination of clusterName/loggingID", d.Id())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be clusterNameorID

ibm/resource_ibm_ob_monitoring.go Outdated
@@ -210,6 +211,9 @@ func resourceIBMMonitoringRead(d *schema.ResourceData, meta interface{}) error {
if err != nil {
return err
}
if len(parts) < 2 {
return fmt.Errorf("Incorrect ID %s: Id should be a combination of clusterName/monitoringID", d.Id())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@kavya498 kavya498 force-pushed the doc branch 3 times, most recently from 91f3003 to 7e7d95a Compare May 10, 2021 06:44
@hkantare hkantare merged commit ea91d84 into IBM-Cloud:master Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kavya498 @hkantare