Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds the capabilities for routers and offering speeds for direct link service #2584

Merged
merged 1 commit into from
May 6, 2021
Merged

Conversation

ajay-malhotra1
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
This PR addresses the following changes to direct link service:
1. Add the capabilities for offering speeds which provides the metered and unmetered billing options for that offering speed
2. Add the capabilities for router representing the macsec and non-macsec capable router

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccIBMDLOfferingSpeedsDataSource_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -run TestAccIBMDLOfferingSpeedsDataSource_basic -timeout 700m
?   	github.com/IBM-Cloud/terraform-provider-ibm	[no test files]
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm	13.708s
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/internal/hashcode	0.343s [no tests to run]
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/internal/mutexkv	0.377s [no tests to run]
?   	github.com/IBM-Cloud/terraform-provider-ibm/version	[no test files]
$ make testacc TESTARGS='-run=TestAccIBMDLRoutersDataSource_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -run TestAccIBMDLRoutersDataSource_basic -timeout 700m
?   	github.com/IBM-Cloud/terraform-provider-ibm	[no test files]
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm	14.104s
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/internal/hashcode	0.222s [no tests to run]
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/internal/mutexkv	0.378s [no tests to run]
?   	github.com/IBM-Cloud/terraform-provider-ibm/version	[no test files]

…t link service

1. Add the capabilities for offering speeds which provides the bmetered and unmetered
billing options for that offering speed

2. Add the capabilities for router representing the macsec and non-macsec capable router
@hkantare hkantare merged commit 91c6c6c into IBM-Cloud:master May 6, 2021
@ajay-malhotra1 ajay-malhotra1 deleted the dl-100g branch May 6, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants