Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support virtual endpoint gateway as target to subnet reserved IP #2521

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Support virtual endpoint gateway as target to subnet reserved IP #2521

merged 1 commit into from
Apr 27, 2021

Conversation

astha-jain
Copy link
Contributor

@astha-jain astha-jain commented Apr 20, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

(venv) astha@Asthas-MacBook-Pro:~/go/src/github.com/IBM-Cloud/terraform-provider-ibm$ TF_ACC=1 go test -v -run=TestAccIBMISSubnetReservedIPResource_basic ./ibm

=== RUN   TestAccIBMISSubnetReservedIPResource_basic
--- PASS: TestAccIBMISSubnetReservedIPResource_basic (105.43s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 106.826s
...

...

hkantare
hkantare reviewed Apr 22, 2021
View reviewed changes
ibm/resource_ibm_is_subnet_reserved_ip.go Outdated
Type: schema.TypeString,
Computed: true,
Optional: true,
Description: "The unique identifier for this endpoint gateway",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the description its wrong

ibm/resource_ibm_is_subnet_reserved_ip.go Outdated
@@ -167,6 +179,10 @@ func resourceIBMISReservedIPRead(d *schema.ResourceData, meta interface{}) error
d.Set(isReservedIPName, *rip.Name)
d.Set(isReservedIPOwner, *rip.Owner)
d.Set(isReservedIPType, *rip.ResourceType)
target, ok := rip.Target.(*vpcv1.ReservedIPTarget)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you first add a check if rip.Target != nil {

}
above files also

@astha-jain
Copy link
Contributor Author

@hkantare This PR is ready for review.

@hkantare hkantare merged commit a0fb640 into IBM-Cloud:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@astha-jain @hkantare