enhancement: added tag support for is_security_group #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkantare
reviewed
Mar 15, 2021
ujjwal-ibm
force-pushed
the
enhancement-sgTagSupport
branch
from
4ffbf6b
to
9604a0c
Compare
hkantare
reviewed
Mar 17, 2021
| @@ -181,6 +216,15 @@ func sgCreate(d *schema.ResourceData, meta interface{}, vpc string) error { | |||
| if err != nil { | |||
| return fmt.Errorf("Error while creating Security Group %s\n%s", err, response) | |||
| } | |||
| v := os.Getenv("IC_ENV_TAGS") | |||
There was a problem hiding this comment.
set the ID and then make a call for tags
ujjwal-ibm
force-pushed
the
enhancement-sgTagSupport
branch
from
9604a0c
to
9a6a4c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tagging support for security group