Enhancement : added default routing table id to output parameters of ibm_is_vpc #2286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkantare
reviewed
Mar 2, 2021
ibm/data_source_ibm_is_vpc.go
Outdated
| @@ -517,6 +524,11 @@ func vpcGetByName(d *schema.ResourceData, meta interface{}, name string) error { | |||
| } else { | |||
| d.Set(isVPCDefaultNetworkACL, nil) | |||
| } | |||
| if vpc.DefaultRoutingTable != nil { | |||
| d.Set(isVPCDefaultRoutingTable, *vpc.DefaultRoutingTable.ID) | |||
| } else { | |||
There was a problem hiding this comment.
Remove else not required if you don't set by default terraform will set to null
| @@ -89,6 +90,14 @@ func resourceIBMISVPC() *schema.Resource { | |||
| Description: "Default network ACL", | |||
| }, | |||
|
|
|||
| isVPCDefaultRoutingTable: { | |||
| Type: schema.TypeString, | |||
There was a problem hiding this comment.
isVPCDefaultRoutingTable here should be only computed and we need to set in Read Method similar to datasource
ujjwal-ibm
force-pushed
the
enhancement-routingTable
branch
from
7cc9992
to
02aa00a
Compare
enhancement : added an output parameter returning the default routing table id
ujjwal-ibm
force-pushed
the
enhancement-routingTable
branch
from
02aa00a
to
9b046b4
Compare
ujjwal-ibm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an output parameter "default_routing_table" which returns the id of the default routing table created
Relates OR Closes #2249