Changes to lock resource record id and zone id #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkantare
reviewed
May 26, 2020
| @@ -355,12 +359,16 @@ func resourceIBMPrivateDNSResourceRecordRead(d *schema.ResourceData, meta interf | |||
| } | |||
|
|
|||
| func resourceIBMPrivateDNSResourceRecordUpdate(d *schema.ResourceData, meta interface{}) error { | |||
| id_set := strings.Split(d.Id(), "/") | |||
| mk := "private_dns_resource_record_" + id_set[2] | |||
There was a problem hiding this comment.
I don't think the lock should be on id_set[2] which is the resource record type ID...Its unique for each resource.
It should be also base don zone_id (id_set[1])
There was a problem hiding this comment.
I am testing whether update works with zone id or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for defect #1430