fix(auth): 로그인 후 콜백 URL 절대경로 처리 수정 - #114
Merged
Merged
Conversation
미들웨어가 callbackUrl을 절대 URL(https://...)로 생성하지만 login, auth/callback 페이지에서 상대 경로만 허용해 로그인 성공 후 원래 페이지 대신 홈(/)으로 리다이렉트되는 문제 수정. - login: 절대 URL을 상대 경로로 변환 후 전달 - auth/callback: URL 파싱으로 pathname 추출하여 리다이렉트 Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough
ChangescallbackUrl 파싱 로직 URL 기반으로 개선
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
callbackUrl을 절대 URL(https://...)로 생성하지만, login/callback 페이지에서 상대 경로만 허용하여 로그인 성공 후 원래 페이지 대신 홈(/)으로 리다이렉트되는 버그 수정login/page.tsx: 절대 URL → 상대 경로 변환 후 전달auth/callback/page.tsx:new URL()파싱으로 pathname 추출하여 리다이렉트Test plan
/diary) 클릭 → 로그인 → 로그인 후/diary로 복귀 확인/mypage) 클릭 → 로그인 → 로그인 후/mypage로 복귀 확인/login접속 → 로그인 → 홈(/)으로 이동 확인🤖 Generated with Claude Code
Summary by CodeRabbit
릴리스 노트