Fix Windows compilation for Crystal 1.13+#7
Merged
I3oris merged 1 commit intoI3oris:mainfrom Aug 27, 2024
Merged
Conversation
Owner
|
Hello HertzDevil, Thank you for this merge request! In effect, On Linux, the |
Contributor
Author
|
Alt+Enter can be disabled in Windows Terminal, not sure about the older console host |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the internal definitions are no longer necessary and clash with a newer stdlib, especially crystal-lang/crystal#14501 which replaces C file descriptors with their underlying Win32 handles.
spec/reader_spec.crwill run on Windows too, however it lacks the proper fiber synchronization. Also it appears REPLy expects the input to use\r\non Windows only, but the specs do not account for that.What was the reason behind making Ctrl+Enter exclusive to Windows? Isn't it easier to just strip the CRLF sequences at the beginning of
Reply::CharReader#parse_escape_sequence?