Recalculate completion entries when crossing :: namespace boundary#6
Recalculate completion entries when crossing :: namespace boundary#6Vici37 wants to merge 1 commit intoI3oris:mainfrom
Conversation
| reader.editor.verify("42.hello") | ||
|
|
||
| SpecHelper.send(pipe_in, "\e\t") # shit_tab | ||
| SpecHelper.send(pipe_in, "\e\t") # shift_tab |
There was a problem hiding this comment.
Was trying to find somewhere to add a spec for this change and discovered this amusing typo
|
Hello @Vici37 ! Thank you very much for this pull request, and all my excuses for the poor delay response. I took a look into this and I found a way to do the same thing that your PR, but being crystal agnostic. I'm will bring this soon :) |
|
I used code in this PR to solve the problem in this commit. I decided to create a new commit because change was to important compared to your PR. The crystal specific code is updated in the IC repository here. However, the code will be effective only when crystal will use the updated version of REPLy, since IC does'nt require REPLy itself, but use the REPLy version of Crystal. |
|
Woo, thank you! |
2 participants
When playing around with
ic, I noticed the tab-completion wasn't helping when I needed to descend down nested module / class names. I added some extra conditions in theon_tabmethod in reply to detect when that was happening and trigger anotheron_completionrun for the new namespace layer.I couldn't think of an effective way to write tests for this, since reply tries to be
crystalagnostic it looks like, and this is fairly crystal specific. Let me know if you have any ideas for writing a spec, would be happy to write any suggestions :)