Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Separate file field in django form constructor #4121

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

WIP: Separate file field in django form constructor #4121

wants to merge 5 commits into from
+34 −0

Conversation

theSage21
Copy link

@theSage21 theSage21 commented Sep 30, 2024 •
edited
Loading

Fixes: #4093

Zac-HD
Zac-HD reviewed Oct 6, 2024
View reviewed changes
Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Arjoon, this looks great!

The only other thing we need before merging is some automated tests, so that we can tell if someone accidentally breaks this feature in a future PR.

hypothesis-python/RELEASE.rst Outdated Show resolved Hide resolved
@theSage21 @Zac-HD
Update hypothesis-python/RELEASE.rst
d63e5e1 
Co-authored-by: Zac Hatfield-Dodds <[email protected]>
@theSage21
Copy link
Author

Thanks Arjoon, this looks great!

The only other thing we need before merging is some automated tests, so that we can tell if someone accidentally breaks this feature in a future PR.

Hey! I will add those soon. Currently caught up in work so not able to give time to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zac-HD Zac-HD Zac-HD left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

django from_form does not work with filefields
2 participants
@theSage21 @Zac-HD