-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support history v5 #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, but do you think this package should maintain compatibility with v4 or just be for v5 and do a major version bump?
I think it's better to support both, as v4 is still used in stable version of React Router |
This looks good. I'll merge and cut a new release tonight. |
BTW, do you have any interest in maintaining this package? I've never actually used it, so I wouldn't mind transferring the repo/npm package to someone who uses it. This is the first time I've had to do something with it in ~2 years, so I don't mind dealing with this occasionally, but I'm also happy to pass it on. |
I'd be happy to pick this, thanks. I'm |
Can you delete your fork? I can't transfer here while your fork exists. |
Done |
Sent the transfer request. Hopefully you won't have much maintenance work to do. I think that the existing setup is pretty straightforward (although not how I would build it now), but feel free to ping me if you have any issues. |
@Hypnosphi, hi do you have any idea on when there might be a new release including this update for history@5? |
@muffinresearch Sorry, I didn't realize I already have corresponding permissions on NPM. |
There are some major API changes in
history@5
, which are addressed in this PR, see remix-run/history#811How to test compatibility with v4:
package.json
&tests/qhistory.spec.js
npm install && npm test