Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support history v5 #5

Merged
merged 2 commits into from
Jul 15, 2020
Merged

Support history v5 #5

merged 2 commits into from
Jul 15, 2020

Conversation

Hypnosphi
Copy link
Owner

There are some major API changes in history@5, which are addressed in this PR, see remix-run/history#811

How to test compatibility with v4:

  • revert changes in package.json & tests/qhistory.spec.js
  • run npm install && npm test

Copy link
Collaborator

@pshrmn pshrmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, but do you think this package should maintain compatibility with v4 or just be for v5 and do a major version bump?

@Hypnosphi
Copy link
Owner Author

I think it's better to support both, as v4 is still used in stable version of React Router

@Hypnosphi Hypnosphi changed the title Support history v5 [WIP] Support history v5 Jul 14, 2020
@Hypnosphi Hypnosphi changed the title [WIP] Support history v5 Support history v5 Jul 14, 2020
@pshrmn
Copy link
Collaborator

pshrmn commented Jul 14, 2020

This looks good. I'll merge and cut a new release tonight.

@pshrmn
Copy link
Collaborator

pshrmn commented Jul 14, 2020

BTW, do you have any interest in maintaining this package? I've never actually used it, so I wouldn't mind transferring the repo/npm package to someone who uses it. This is the first time I've had to do something with it in ~2 years, so I don't mind dealing with this occasionally, but I'm also happy to pass it on.

@Hypnosphi
Copy link
Owner Author

I'd be happy to pick this, thanks. I'm hypnosphi on NPM

@pshrmn pshrmn merged commit a41f668 into Hypnosphi:master Jul 15, 2020
@pshrmn
Copy link
Collaborator

pshrmn commented Jul 15, 2020

Can you delete your fork? I can't transfer here while your fork exists.

@Hypnosphi
Copy link
Owner Author

Done

@pshrmn
Copy link
Collaborator

pshrmn commented Jul 15, 2020

Sent the transfer request. Hopefully you won't have much maintenance work to do. I think that the existing setup is pretty straightforward (although not how I would build it now), but feel free to ping me if you have any issues.

@muffinresearch
Copy link

@Hypnosphi, hi do you have any idea on when there might be a new release including this update for history@5?

@Hypnosphi
Copy link
Owner Author

Hypnosphi commented Jul 29, 2020

@muffinresearch Sorry, I didn't realize I already have corresponding permissions on NPM. 1.1.0 is published now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants