Enhance look and feel of the submission results page #4200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theskumar
changed the title
theskumar
changed the title
frjo
requested changes
Nov 6, 2024
There was a problem hiding this comment.
Overall looks good, some minor issues on smaller screens/windows.
- I prefer left aligned headers but lets see what other people feel about that.
- On smaller screens large numbers overflow. Maybe take the size down a notch?
- Can we remove "Your" to make it shorter and make sure it does not wrap?
- Decimals are not really needed here I think, we can round the numbers instead. That would help with the overflow issue in 2.
|
Updating to accept a fairly large numbers now. Updating the decimal formatting is tricky unless we make a hard choice of not using babel to convert into locale based formatter. Screenshot.2024-11-07.at.8.25.44.mp4 |
theskumar
force-pushed
the
enchancement/submission-report-style
branch
from
df203c6
to
cdbfd8e
Compare
frjo
added
Type: Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After