Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pre-commit in ci to check for lint issues #4110

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Use pre-commit in ci to check for lint issues #4110

merged 2 commits into from
Oct 17, 2024

Conversation

theskumar
Copy link
Member

@theskumar theskumar commented Aug 25, 2024 •
edited
Loading

  • Add eslint and stylint to pre-commit
  • Update .github workflow
  • upgrade ruff
  • Make mirror-eslint work (ps: it doesn't seem to find the "globals" package if not installed with npm install explicitly
  • Add timeout to each task

@theskumar theskumar marked this pull request as ready for review August 25, 2024 20:26
@frjo frjo added Type: Maintenance Type: Patch Mini change, used in release drafter labels Aug 26, 2024
@theskumar theskumar requested a review from frjo October 12, 2024 15:28
@theskumar theskumar force-pushed the ci-lint-update branch 2 times, most recently from bbfe20f to 38ad894 Compare October 16, 2024 06:58
@theskumar
Use pre-commit in ci to check for lint issues
1ff65d7 
Add eslint to pre-commit

Add eslint and stylint to pre-commit

Update .github workflow

upgrade ruff

Make mirror-eslint work
@theskumar theskumar requested a review from frjo October 17, 2024 04:35
@frjo frjo merged commit 8b9c8c8 into main Oct 17, 2024
8 checks passed
sandeepsajan0 pushed a commit that referenced this pull request Oct 18, 2024
@theskumar @sandeepsajan0
Use pre-commit in ci to check for lint issues (#4110)
d4b640c 
- Add eslint and stylint to pre-commit
- Update .github workflow
- upgrade ruff
- Make mirror-eslint work (ps: it doesn't seem to find the "globals"
package if not installed with npm install explicitly
- Add timeout to each task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frjo frjo Awaiting requested review from frjo

Assignees
No one assigned
Labels
Type: Maintenance Type: Patch Mini change, used in release drafter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theskumar @frjo