Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoice status updating improvements #4083

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

wes-otf
Copy link
Contributor

@wes-otf wes-otf commented Aug 9, 2024

Fixes #3208. Implemented an improvement for the picklist where radio buttons will be shown when there are less than 4 options. Otherwise the prompt will be like it was before.

This PR also implements HTMX for the invoice updating prompt, allowing invoices in table to be updated w/o refreshing the pages

Test Steps

@wes-otf wes-otf added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Minor Minor change, used in release drafter labels Aug 9, 2024
Copy link
Member

@theskumar theskumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wes-otf instead of rendering each of the one by one during initial page load, either you can load the invoices from server as it was getting loaded before and only when the status changed update the row data.

Or if you want to save up some queries and load the invoices section async, then I would suggest load all the rows at once, and then when a particualar invoices is update either re-render all the invoices row or just trigger fetch and update of a single row.

@wes-otf wes-otf force-pushed the enhancement/improve-picklist-usability branch from 91d0219 to 5afec10 Compare August 12, 2024 21:19
@wes-otf wes-otf requested review from frjo and theskumar August 13, 2024 21:51
@wes-otf wes-otf marked this pull request as ready for review August 13, 2024 21:51
@frjo
Copy link
Contributor

frjo commented Aug 14, 2024

@wes-otf You can update invoice status on the invoice detail page as well. I think that function also need to be updated to use htmx, getting some errors when using it now.

@frjo
Copy link
Contributor

frjo commented Aug 14, 2024

@wes-otf When you are on the invoice detail template can you make it so the show/hide for activities only show when there are more than 1 activity?

@wes-otf wes-otf force-pushed the enhancement/improve-picklist-usability branch from 2c043f8 to ebb7e0d Compare August 14, 2024 18:01
@wes-otf
Copy link
Contributor Author

wes-otf commented Aug 14, 2024

thanks for the catch @frjo, totally missed that. I think all should work now - didn't update the batch prompt because that seems a little out of scope but that'll probably be in line next

Copy link
Contributor

@frjo frjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

@frjo frjo added Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team and removed Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Aug 22, 2024
@frjo
Copy link
Contributor

frjo commented Aug 27, 2024

Some merge conflicts in invoices.html with other PRs on test so waiting a bit.

@frjo frjo added the Status: RTBC Internal Dev use only label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: RTBC Internal Dev use only Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Minor Minor change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve usability of picklist on project page
3 participants