Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Make it easy for staff to close rounds & filter on unpublished rounds #3869

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wes-otf
Copy link
Contributor

@wes-otf wes-otf commented Apr 10, 2024

Fixes #3867. Closed rounds now include unpublished rounds

Test Steps

@wes-otf wes-otf added Type: Bug Bugs! Things that are broken :-/ Type: Patch Mini change, used in release drafter labels Apr 10, 2024
Copy link
Member

@sandeepsajan0 sandeepsajan0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I unpublished an open round it is shown in both tabs open and closed on the staff dashboard. I think It is because previously open and close both were filtered via date and now we have added not-live to closed so date-wise it is open but it is not live so it is closed as well.

image

image

@sandeepsajan0
Copy link
Member

I am not sure but l think it might be confusing for staff because right now rounds are closed only if their end date has been passed. But now in admin, open unpublished rounds will be shown in the closed tab, technically it is correct but it might be confusing.

Do we know the use case why staff is unpublishing a round, do they want to close it or just want to take it down for some time? Because if it just for some time and want to reopen it again then a separate filter unpublished might help better otherwise closed rounds will be a long list.

@wes-otf
Copy link
Contributor Author

wes-otf commented Apr 16, 2024

@sandeepsajan0 I agree, I think it might be better to move toward unpublished being a filter and giving more clarity/making it easier to just close a round

@wes-otf wes-otf changed the title Unpublished rounds now show up under closed in Wagtail admin & other filters WIP: Make it easy for staff to close rounds & filter on unpublished rounds Apr 18, 2024
@wes-otf wes-otf marked this pull request as draft April 18, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bugs! Things that are broken :-/ Type: Patch Mini change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closed rounds should include unpublished rounds
2 participants