-
Notifications
You must be signed in to change notification settings - Fork 1
0718 remote batch reward #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0718 remote batch reward #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个 base 类当时在 harpy 里是会有不同类型的 tools 继承(比如 model / api),所以这样写,我们这里只有一个 api tools 的话感觉可以把这个去掉,直接实现一个就好
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的更改看起来只有 debug 的注释,是不是可以去掉
| res = math_verify.compute_score(solution_str, ground_truth) | ||
| elif data_source == 'math_dapo' or data_source.startswith("aime") or data_source.startswith("dapo_"): | ||
| elif data_source in [ | ||
| 'train-math-numinamath1.5_aops_forum', 'DeepScaleR_no_system', 'dapo_aime2025_s32_no_system', 'dapo_aime2024_s32_no_system', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我记得这里有一些非 int 的,也可以用 dapo reward吗
…red from response[-300:0]
5b9cf96
into
run_sensecore_merge_verl_0626
Checklist Before Starting
What does this PR do?
High-Level Design
Specific Changes
API
Usage Example
# Add code snippet or script demonstrating how to use thisTest
Additional Info.
Checklist Before Submitting
[BREAKING]to the PR title if it breaks any API.