Refactor Language Config & Update Navbar for future i18n support #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t changes for i18n
|
@Metalhearf Can you create a README on how they can do the translation ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: Refactor Language Configuration & Update Navbar
Changes:
These changes improve the structure of the language configuration and enhance user experience with this navigation. I'm up for changes/renames etc.
Personal Note:
It seems that in order to properly support i18n with Starlight, the default language (English/root) must be placed in
src/docs/content/xxx, and other languages should be in separate folders like/fr/,/nl/at the same level. I don't find this structure ideal, but it should work for now and it's invisible for users browsing the site.See withastro/starlight#1008.
Screenshot (Before / After)