Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android | Clicking android hardware back button on splash screen opens blank screen #36

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

usmankhan495
Copy link

@usmankhan495 usmankhan495 commented Jun 20, 2022

Issue
[Android | Clicking android back button on splash screen opens blank screen]

react-native-lottie-splash-screen is using Android dialog to render the lottie animation as per the code of react-native-lottie-splash-screen it is opening the dialog and when user press the hardware back button on andorid device this closes the Android dialog, which show the blank screen of MainActivity.java

Solution
I am preventing Android dialog to close on hardware back press. As per the Android dialog documentation there is a method available to achieve this.

@HwangTaehyun
Copy link
Owner

HwangTaehyun commented Jun 22, 2022

@usmankhan495 Could you open this issue? And then, please refer to the issue in this PR.
Thank you for your contribution! I will check it out this weekend.

@usmankhan495
Copy link
Author

Hi @HwangTaehyun
did you get the time to review this?

@HwangTaehyun
Copy link
Owner

Sorry for the late. It works!

@HwangTaehyun HwangTaehyun merged commit 62aac7b into HwangTaehyun:master Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants