Refactor ToOrdinalWords to use existing NumberToWordsExtension #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,6 +9,7 @@ | |||
| - [#151](https://github.com/MehdiK/Humanizer/pull/151): Added Spanish ToWords Translations | |||
| - [#172](https://github.com/MehdiK/Humanizer/pull/172): Added Polish translation for ToWords | |||
| - [#184](https://github.com/Mehdik/Humanizer/pull/184): Fixed spelling error with forth/fourth in EnglishNumberToWordsConverter | |||
| - [#186](https://github.com/Mehdik/Humanizer/pull/186): Refactored 'ToOrdinalWords` to use existing `NumberToWordsExtension` to prepare for Ordinal localization. | |||
There was a problem hiding this comment.
You've added your PR to v1.20.2. Please add it to In Development section.
|
Fixed! |
MehdiK
added a commit
that referenced
this pull request
Apr 11, 2014
Refactor ToOrdinalWords to use existing NumberToWordsExtension
|
That was quick :) Thanks. |
|
The web UI is very useful for these situations. Now I can work on my Spanish ToOrdinalWords PR later today/tomorrow. |
|
Cool :) Looking forward to it. That would be the first localisation of ordinal words. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
ToOrdinalWordsto use existingNumberToWordsExtensioninstead of a separateNumberToOrdinalWordsExtensionextension.This change allows contributors to start localizing the Ordinal words.