-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function name prefix #13
Comments
Not sure this is a good idea. The standard way to solve this issue is the use of namespaces instead of making all function names longer. All functions in the collar library should be in the collar namespace so should be used as follows: collar::foo |
The reason for doing it is speed/convenience. Those using editors with
auto-complete can type cllr and see all the functions in the package. It
is in the spirit of stringr. If you don't like it we can reconsider. I
like having a crutch and while namespaces do help avoid name collision it
doesn't solve the problem without explicit calls.
|
I don't have a strong opinion about this and another person brought up the same idea of dropping the object_verb naming convention. We should revisit the conversation |
Have revisited several times now and looks like we are working towards families of functions. All of the fetch_* functions retrieve data for example. I think this is a nice hybrid solution, other thoughts? |
Thanks for the feedback @kissmygritts I think I agree with you. I would like to reorganize the package a bit and this could be part of that effort. |
I will propose that we prefix every function name with cllr. This will make it easy to find functions in RStudio using the suggestions, so a function might be called cllr_foo or cllr_fetch_csv or whatever, but it will always start with cllr. Other suggestions?
The text was updated successfully, but these errors were encountered: