Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Help not found in Docker #146

Merged
merged 11 commits into from
Dec 31, 2023
Merged

[BUG] Help not found in Docker #146

merged 11 commits into from
Dec 31, 2023

Conversation

ProgramComputer
Copy link

@ProgramComputer ProgramComputer commented Sep 25, 2023 •
edited
Loading

Help not found when clicked on when running on Docker and causes error.

@ProgramComputer ProgramComputer changed the base branch from master to dev October 3, 2023 05:52
@ProgramComputer ProgramComputer changed the title Help not found in Docker [BUG] Help not found in Docker Oct 4, 2023
@HugoFara HugoFara added documentation Improvements or additions to documentation wontfix This will not be worked on docker Anything related to Docker labels Dec 25, 2023
@ProgramComputer ProgramComputer mentioned this pull request Dec 30, 2023
Closed
@HugoFara
Copy link
Owner

HugoFara commented Dec 31, 2023 •
edited
Loading

Hi there, I thought a bit about the issue and its implications. Here are the main aspects:

  • docs/ is 14 MB of dead weight as I don't think the full documentation is necessary for most users.
  • docs/info.html is referenced everywhere as the "all documentation in one file" element.
  • The automatic documentation (docs/*/) is 13.5 MB.

As long as we ignore the folders in docs, the overhead stays under control and the documentation is partially accessible. In the worst case a Docker user needs the full documentation in his container, it is still possible to regenerate it.

Could you modify your pull request by ignoring the folders only?

@ProgramComputer ProgramComputer force-pushed the patch-2 branch 2 times, most recently from 5482db8 to 4aacebb Compare December 31, 2023 15:29
@HugoFara HugoFara merged commit 01868b1 into HugoFara:dev Dec 31, 2023
@HugoFara HugoFara linked an issue Dec 31, 2023 that may be closed by this pull request
PHP warning on index.php with Docker install #160
Closed
@HugoFara HugoFara removed a link to an issue Dec 31, 2023
PHP warning on index.php with Docker install #160
Closed
HugoFara added a commit that referenced this pull request Dec 31, 2023
@HugoFara
Adds #146 to the changelog.
b0102a6
@ProgramComputer ProgramComputer deleted the patch-2 branch January 2, 2024 17:21
HugoFara added a commit that referenced this pull request Jan 3, 2024
@HugoFara
Merge all features from dev branch.
0bc776f 
New databse migration strategy.
Fixes feeds (#168).
Adds missing documentation to Docker (#146, #160).
Changes in PHP and JS globals.
Fixes reading position was not set.
Read text through API (#153, #155).
Fixes word was not saved/deleted.
Fixes #170 and #69.
Updates API (#175).
Adds dependency to php-xml (#178, #181).
Updates makefile (#179).
Adds MeCab support on Mac (#135).
Adds the option to hide/show word romanization (#119).
Raises URL size limit to 2048 (#144).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docker Anything related to Docker documentation Improvements or additions to documentation wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ProgramComputer @HugoFara