fix(CF Stack): Route53DependencyLambda zone matching logic #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(CF stack): Route53DependencyLambda zone matching logic
|
👋 Just a heads up for anyone who comes across this PR. I deleted the original user that created this, which is why it's now a "ghost". I'm still here and still interested in having this PR merged. Thanks ^_^ |
Chore/update cf template
Feat/cf stack
feat: include newest Hubs CF Template
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the matching logic present in the
Route53DependencyLambdasection of the CloudFormation Stack.We found that by excluding the
properties.Domain.split(".")logic and instead simply comparingzone.Namewithproperties.Domain + '.'we were able to spin up a new instance of Hubs using a sub-domain who's root domain was not hosted on Route53. This means that both Domain Recipe 1 and 2 are able to be used on any given domain name as long as that domain has a Route53 Hosted Zone. It might, we haven't tested it, also mean that the.co.ukbug should also be fixed.IE:
hubs.mydomain.comcan haveNSrecords pointing to a Route53 Hosted Zonemydomain.comcan be hosted with another DNS providerhubs.mydomain.comcan still be used as the external hosted zone when creating a Hubs instancePreviously:
hubs.mydomain.comandmydomain.comboth had to be hosted via Route53