fix handling of bit column type#7
Closed
sougou wants to merge 8 commits intoHubSpot:couple_fixesfrom
sougou:bitfix
Closed
fix handling of bit column type#7sougou wants to merge 8 commits intoHubSpot:couple_fixesfrom sougou:bitfix
sougou wants to merge 8 commits intoHubSpot:couple_fixesfrom
sougou:bitfix
Conversation
* Change ExprFromValue to use categorization functions. * Added unit test for ExprFromValue. * Fixed bit default value handling, with unit and endtoend tests.
Author
bbeaudreault
force-pushed
the
couple_fixes
branch
from
e754dbd to
a1facf6
Compare
Member
|
I rebased my branch and cherry-picked your commit into it instead, to avoid the merge commit and such. Thanks for doing this! See the original PR vitessio#3110 for the new additions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged into hubspot repo before getting submitted back to youtube.
I had to also merge the latest changes from master. Didn't have enough git-fu to isolate just my changes.
But you can look at my last commit, which is the only material change.