Don't close while holding lock#13
Merged
zklapow merged 1 commit intohubspot-client-betafrom Mar 19, 2019
Merged
Conversation
|
LGTM, we only needed the lock for mutating the |
Member
Author
|
yup (we do the close from a separate thread in some cases anyhow) |
zklapow
added a commit
that referenced
this pull request
Apr 2, 2019
jschlather
added a commit
that referenced
this pull request
Apr 9, 2019
* Add .build-jdk8 * don't close while holding lock (#13) * Add temporary info logging statement for slow queries.
olyazavr
pushed a commit
that referenced
this pull request
May 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can cause this lock to be held for a very long time, causing contention and possibly connection acquisition timeouts.
@jschlather