Fix performance issues with large tables #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also using this patched version in Kubernetes Resource Report: https://codeberg.org/hjacobs/kube-resource-report/pulls/27 |
mayank941
pushed a commit
to mayank941/kuberesource
that referenced
this pull request
Aug 25, 2021
`sortable.min.js` has a problem with large (~5k rows) tables (browser stuck ~20s). This uses the patched version from HubSpot/sortable#54 Co-authored-by: Henning Jacobs <[email protected]> Reviewed-on: https://codeberg.org/hjacobs/kube-resource-report/pulls/27 Co-authored-by: Henning Jacobs <[email protected]> Co-committed-by: Henning Jacobs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This address #50: sorting large tables (~5k rows) was causing ~20 second hang that hogs CPU and makes the whole browser unresponsive. This was caused by too many "recalculating browser styles" when doing
appendChildon thetbody. Moving the nodes temporarly into a DocumentFragment and then adding the fragment to the body will cause less browser style calculations and decreased the sorting of large tables from >20s to <3s on my machine.