Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Base 64 encode and decode filters #763

Merged
merged 3 commits into from
Oct 6, 2021
Merged

Add Base 64 encode and decode filters #763

merged 3 commits into from
Oct 6, 2021

Conversation

jasmith-hs
Copy link
Contributor

Adds 2 new filters:

  • b64encode
  • b64decode

Each of them default to using UTF-8, but you can specify the charset as one of:

US_ASCII
ISO_8859_1
UTF_8
UTF_16BE
UTF_16LE
UTF_16

(If running on a machine that supports more charsets, you can use one of those too).
These filters are both supported in ansible

For #743

jmaroeder
jmaroeder requested changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@jmaroeder jmaroeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Just a couple missing snippets that I see

src/main/java/com/hubspot/jinjava/lib/filter/Base64DecodeFilter.java Outdated
)
},
snippets = {
@JinjavaSnippet(code = "{% set my_number = -53 %}\n" + "{{ my_number|abs }}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you copied this over from AbsFilter - should probably update it to use b64decode

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, thanks for catching this!

src/main/java/com/hubspot/jinjava/lib/filter/Base64EncodeFilter.java Outdated
)
},
snippets = {
@JinjavaSnippet(code = "{% set my_number = -53 %}\n" + "{{ my_number|abs }}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update this to use b64encode

Joeoh
Joeoh approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@Joeoh Joeoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

@jasmith-hs jasmith-hs merged commit ca99246 into master Oct 6, 2021
@jasmith-hs jasmith-hs deleted the b64-encode branch October 6, 2021 14:48
@ssalonen ssalonen mentioned this pull request Aug 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmaroeder jmaroeder jmaroeder requested changes

@Joeoh Joeoh Joeoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasmith-hs @jmaroeder @Joeoh