Limit infinite evaluation from recursive extends tags #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmith-hs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent infinite levels of extends tags being called when there is an extended child that has a child that extends itself. The basic stack way of detecting extends tag cycles did not catch this case. So this PR adds in a set that remembers the paths that have been extended when processing them and if any ever get encountered more than once, it will break and add an interpreter error.
The test case that I added is a simple demonstration of what caused infinite execution. This PR fixes that case.
cc @kacperadach @hs-lsong @bkrainer