Handle spaces better in for loop expressions #706
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for "For loop" expressions is pretty wonky. Let's clean it up a bit and allow Jinjava to support for loops with maps that contain spaces. For example:
Currently this gets transformed into:
which is invalid syntax. (Notice the commas after the colons)
This PR makes that not happen by never splitting up the expression. Instead we look for
" in "
and treat everything after that as the loop expression. The previous logic did this, but in a more convoluted way by first splitting up all the helpers (treating spaces and commas the same way) and then rejoining them with commas.