-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Assignment Blocks with Set tags #698
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmith-hs
commented
Jun 25, 2021
jasmith-hs
commented
Jun 25, 2021
Comment on lines
+126
to
+136
@Test | ||
@Ignore | ||
public void itSetsBlock() { | ||
// not implemented yet | ||
} | ||
|
||
@Test | ||
@Ignore | ||
public void itSetsBlockWithFilter() { | ||
// not implemented yet | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is complex to properly support this with eager execution so it's in a separate PR #699
jmaroeder
approved these changes
Jul 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one question for my understanding!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #693 and #422
Jinja 2.8 adds support for block set assignments (https://jinja.palletsprojects.com/en/3.0.x/templates/#block-assignments)
Add support for set tags with the notation:
foo = 'A value of 2'
Additionally, Jinja 2.10 adds support for filters in the assignments:
foo = 'HELLO'
.The
FlexibleTag
interface adds a way to determine Node-based eligibility for requiring anEndTag
rather than Tag-based eligibility through thehasEndTag(TagToken tagToken)
method. Since this method takes aTagToken
as the parameter, whether or not the tag will have a corresponding endtag depends on what is in the TagToken. ForSetTag
, it depends on whether there is an=
in the helpers.I'm opening this PR separately from the logic to handle this change with Eager Execution because those changes are much larger.