[Eager Execution] Track null values as completed in EvalResultHolders #634
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the EvalResultHolders, if
super.eval()
returns null, we should count that as having an evaluation result. Therefore we need a separate boolean to keep track of if there's an eval result rather than simply tracking if theevalResult != null
. A strong example is a custom void function. It will return null when evaluated, but we want to track that it has been called already (in case of a DeferredParsingException) so that it doesn't get called twice.Instead of writing test classes for every kind of AstNode, I just wrote a simple one for EagerAstIdentifier that makes sure a null context value will be stored as the eval result and that we know that the AstIdentifier has already been evaluated when it finds that.
This was found/is needed to make a test case pass in #632 after its merge with master due to #629