Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hacky replaceL behavior #407

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Remove hacky replaceL behavior #407

merged 1 commit into from
Mar 9, 2020

Conversation

mattcoley
Copy link
Collaborator

This behavior has been here since initial commit but is pretty strange. Basically if we detect the format is a Java format rather than strftime format, we return the Java format back but replace all LLLL instances with MMMM. This means we can't manually specify LLLL when that is the appropriate format we want.

@mattcoley mattcoley requested a review from boulter March 6, 2020 18:30
@boulter
Copy link
Contributor

boulter commented Mar 6, 2020

Probably had something do with python compatibility? Worth checking for differences in any case.

@mattcoley
Copy link
Collaborator Author

That's my plan. I am not sure how this would affect python compatibility since python would be using the stftime format with %, not the Java datetime format that we convert the strftime into.

@mattcoley
Copy link
Collaborator Author

I ran the diff report 5 times. The only diffs were expected. Languages that have genitive months are now properly using the genitive format.

@mattcoley mattcoley merged commit 06ce543 into master Mar 9, 2020
@mattcoley mattcoley deleted the remove-replace-L branch March 9, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants