Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement jinja2.ext.loopcontrols extensions #1219

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Nov 23, 2024

@ccutrer
Copy link
Contributor Author

ccutrer commented Dec 4, 2024

@jasmith-hs any chance you could take a look at this? Is there any possibility of getting it in and a new release cut this week? It's blocking a pretty big automation integration between openHAB and Zigbee2MQTT, and openHAB is going into feature freeze next week.

Copy link
Contributor

@jasmith-hs jasmith-hs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try. This looks good and I have a quick follow-up PR I'm ready to open to make this compatible with eager execution

@jasmith-hs jasmith-hs merged commit 1996571 into HubSpot:master Dec 6, 2024
2 checks passed
@ccutrer ccutrer deleted the loop-extensions branch December 6, 2024 15:27
@ccutrer
Copy link
Contributor Author

ccutrer commented Dec 6, 2024

Awesome! Thank you so much

I saw code for eager execution and deferred values, but I don't fully understand what either are. I'll be watching for your follow up PR to increase my understanding.

@jasmith-hs
Copy link
Contributor

Awesome! Thank you so much

I saw code for eager execution and deferred values, but I don't fully understand what either are. I'll be watching for your follow up PR to increase my understanding.

It will take a bit of work to be able to handle them in eager execution, I'm planning to work alongside a new engineer on my team to do that. But getting the incompatibility marked as unsupported is an easy change for me to make: #1222

@jasmith-hs
Copy link
Contributor

@ccutrer 2.7.4 has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants