add warnings when datetime-related filters called with null arguments #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boulter
commented
May 1, 2023
| import org.junit.Test; | ||
|
|
||
| public class BetweenTimesFilterTest extends BaseJinjavaTest { | ||
|
|
||
| @Before | ||
| public void setup() { | ||
| jinjava.getGlobalContext().registerClasses(EscapeJsFilter.class); |
There was a problem hiding this comment.
seems like this was copied from some other test
jasmith-hs
approved these changes
May 1, 2023
Oh weird, I had one. Where did it go? |
boulter
deleted the
jboulter-add-warnings-when-datetimefilters-called-with-null-arguments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future we may change this behavior so null args do not default to the current time. I suspect many users didn't know this was happening since there was no warning.