Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade jackson #1051

Merged
merged 5 commits into from
Jun 9, 2023
Merged

upgrade jackson #1051

merged 5 commits into from
Jun 9, 2023

Conversation

boulter
Copy link
Contributor

@boulter boulter commented Apr 14, 2023

Upgrades to avoid CVE mentioned in #1050

@boulter boulter requested a review from jasmith-hs April 28, 2023 19:50
Copy link
Contributor

@jasmith-hs jasmith-hs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure that this logic still works:

if (e instanceof LengthLimitingJsonProcessingException) {
throw new OutputTooBigException(
((LengthLimitingJsonProcessingException) e).getMaxSize(),
((LengthLimitingJsonProcessingException) e).getAttemptedSize()
);
}

@boulter boulter requested a review from jasmith-hs May 1, 2023 18:31
@jowiho
Copy link

jowiho commented Jun 9, 2023

In the meantime Jackson 2.15.2 is the latest stable version. I've confirmed that this PR builds and tests correctly with that Jackson version as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants