Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Rename Mode to CmsPublishMode #1269

Open
wants to merge 3 commits into
base: next
Choose a base branch
from
Open

Conversation

camden11
Copy link
Contributor

@camden11 camden11 commented Nov 22, 2024

Description and Context

See issue: https://git.hubteam.com/HubSpot/hubspot-cli-issues/issues/718
and LDL PR: HubSpot/hubspot-local-dev-lib#216

This updates the CLI to handle LDL's renamed exports related to CmsPublishMode. It also changes all references to mode in the CLI to cmsPublishMode, including the --mode flag that can be passed to commands.

TODO

  • Test thoroughly
  • remove LDL experimental dep

Who to Notify

@brandenrodgers @kemmerle @joe-yeager

@camden11 camden11 changed the base branch from main to next November 22, 2024 22:16
@camden11 camden11 changed the title Update global flags 2 Rename "Mode" to "CmsPublishMode" Nov 22, 2024
@camden11 camden11 changed the title Rename "Mode" to "CmsPublishMode" Rename Mode to CmsPublishMode Nov 22, 2024
@camden11 camden11 marked this pull request as ready for review November 22, 2024 22:30
@camden11 camden11 changed the title Rename Mode to CmsPublishMode chore!: Rename Mode to CmsPublishMode Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant