Refactor function commands #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandenrodgers
requested review from
camden11,
kemmerle and
joe-yeager
as code owners
joe-yeager
approved these changes
Nov 22, 2024
commands/function.ts
Outdated
Comment on lines
14
to
17
| .command({ | ||
| ...list, | ||
| aliases: 'ls', | ||
| }) |
There was a problem hiding this comment.
Should we move this to the command field in the list subcommand?
There was a problem hiding this comment.
Ah yeah I saw you did that in another PR. I'll do the same 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
This refactors the functions commands to conform to our guidelines. Major changes:
hs logs
--versionflag because it's unnecessaryendpointshould be kept as a positional and should fall back to a prompt when not specifiedhs functions
--helpflag because they don't do anythinghs function, but we should continue to supporths functionshs functions list
Screenshots
TODO
Who to Notify