Fix PHP 8.4 deprecate #430
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge this pull request, my logs are being spammed by this deprecation error 😞 @ksvirkou-hubspot could you please merge this? 👍🏻 |
Collaborator
|
The SDK is auto-generated based on swagger files that is why we can't change codegen manually. |
|
@ksvirkou-hubspot any ideas when this will be fixed in a future release? |
|
@ksvirkou-hubspot, which codegen do you use for the generation? |
Collaborator
Open API Generator |
In Open API Generator v.7.12, these deprecations in generated code were fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add nullable
?operator for all nullable/optional properties.Used PhpStorm's code inspections to fix all these deprecations automatically, but ~1500 files are modified 😅.
Ref