cast output committer to PathOutputCommitter to allow S3 magic committer #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnysohn
requested review from
bbeaudreault,
cathturner,
cgagen14,
ddelong and
vinayvija
Member
bbeaudreault
left a comment
bbeaudreault
left a comment
There was a problem hiding this comment.
We don't keep patches like this in our hbase fork. Can you describe why this cast matters? We can consider pushing an upstream fix if there's a bug but it seems odd to me
Member
|
Ok so is the problem we are getting a ClassCastException? We can fix this upstream. |
Member
|
I created https://issues.apache.org/jira/browse/HBASE-28459 for this. I think it's an easy patch to make. We can merge this for now to unblock and prioritize fixing upstream in the immediate future. |
bbeaudreault
added
the
upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to apache/avro#1431, output committer needs to be casted to PathOutputCommitter instead of FileOutputCommitter to allow S3 Magic committer as output committer. PathOutputCommitter is only available starting from Hadoop 3 so this change isn't backwards compatible with HBase using Hadoop 2.