Fix backport of AVOID_LOCAL_WRITES #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
ITBLL fails with the latest hubspot-2.5 build. Confirmed that upgrading to this build fixes it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WAL requires non-EC. The builder we use for creating the WAL output stream calls
builder.replicate()which basically overrides any EC policy with default replication as a precaution. There was a copy/paste error in the backport of this feature to our fork, which accidentally overrides the thereplicateMethodwith a reflection of thenoLocalWritemethod. So when we go to callreplicate()to ensure non-EC, we're actually callingnoLocalWrite().This bug is not present in the upstream backports, but this time the hubspot backport was done separately. Here I fix the copy/paste so we don't override the replicateMethod.