-
Notifications
You must be signed in to change notification settings - Fork 7
WIP : HBASE-26809 : backoff metrics #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
briaugenreich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few things i wanted to clarify before testing + adding the last metric location
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncBatchRpcRetryingCaller.java
Outdated
Show resolved
Hide resolved
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
Outdated
Show resolved
Hide resolved
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
Outdated
Show resolved
Hide resolved
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
Outdated
Show resolved
Hide resolved
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
Outdated
Show resolved
Hide resolved
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
Outdated
Show resolved
Hide resolved
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncBatchRpcRetryingCaller.java
Outdated
Show resolved
Hide resolved
|
Updated to produce metrics only during times of server overload. Now I have two remaining questions.
|
|
Okay... updated to resolve question #2 I posted above and ran the following tests... The only remaining item I'm looking into is if I need to make additional changes to some of the other b74747c#diff-1c9b1c63630f33e323daf8f874758e9efc5ec6ed4a40f2456db4bbd82209cac4R102 |
969283d to
6441872
Compare
|
@bbeaudreault should this go in a particular 2.0 version or can I just open on branch-2? |
|
Sorry i just saw this -- Let's close this PR and you can open a new PR against branch-2. Generally we PR against master first (done), then it might just get cherry-picked to the rest (didn't work here), so then we do branch-2, then it might get cherry-picked to the rest (probably will work, we'll see), then we do others like branch-2.5, etc depending on how far back we want to backport. |
|
Got it, thanks! yeah the cherry pick against branch 2 has so many merge conflicts I think I'm going to have to manually apply these. |
mostly opening here to get some feedback before opening upstream pr.
https://issues.apache.org/jira/browse/HBASE-26809