Request Priority API #2245
Merged
Request Priority API #2245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssalinas
reviewed
Nov 17, 2021
| @@ -3,6 +3,7 @@ | |||
| public enum SingularityAction { | |||
| BOUNCE_REQUEST(true), | |||
| SCALE_REQUEST(true), | |||
| PRIORITIZE_REQUEST(true), | |||
There was a problem hiding this comment.
quick note, there is an equivalent list in SingularityUI code that mirrors this enum
Comment on lines
35
to
36
| PRIORITIZED, | ||
| PRIORITY_REVERTED |
There was a problem hiding this comment.
are we able to maybe fold these into UPDATED instead somehow? these fields come through on things that a lot of other systems pull in and the roll out can be a pain with the deployer/etc having to know about all the new fields first. If the purpose is just to indicate the action more easily, we can always have the messge text reflect that, which will also show in the UI
added 10 commits
November 17, 2021 10:58
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an API for modifying request scheduling priority, similar to the request scale API, for cases where specific requests need to be prioritized/deprioritized temporarily or permanently.
Skipped email support, because this isn't intended to be a common action.
Can add UI support similar to the request scale API to this PR, if desired.
cc - @ssalinas, @pschoenfelder