Skip to content

Commit

Permalink
Merge pull request #2064 from HubSpot/run-now-modal-focus
Browse files Browse the repository at this point in the history
Prevent request action modals from closing upon regaining focus
  • Loading branch information
WH77 authored Jan 31, 2020
2 parents 0efb9e1 + 34d0fbd commit bb4d68f
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 2 deletions.
15 changes: 15 additions & 0 deletions SingularityUI/app/actions/ui/requestDetail.es6
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,21 @@ import { FetchTaskCleanups, FetchScheduledTasksForRequest } from '../api/tasks';
import { FetchRequestUtilization } from '../api/utilization';

export const refresh = (requestId) => (dispatch, getState) => {
const requiredPromises = Promise.all([
dispatch(FetchRequest.trigger(requestId)),
dispatch(FetchRequestHistory.trigger(requestId, 5, 1)),
])

dispatch(FetchActiveTasksForRequest.trigger(requestId));
dispatch(FetchTaskCleanups.trigger());
dispatch(FetchDeploysForRequest.trigger(requestId, 5, 1));
dispatch(FetchScheduledTasksForRequest.trigger(requestId));
dispatch(FetchRequestUtilization.trigger(requestId, [404]))

return requiredPromises;
}

export const initialize = (requestId) => (dispatch, getState) => {
const requiredPromises = Promise.all([
dispatch(FetchRequest.trigger(requestId)),
dispatch(FetchRequestHistory.trigger(requestId, 5, 1)),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ import RequestUtilization from './RequestUtilization';

import Utils from '../../utils';

import { refresh } from '../../actions/ui/requestDetail';
import { FetchRequestShuffleOptOut } from '../../actions/api/requests.es6';
import { refresh, initialize } from '../../actions/ui/requestDetail';

class RequestDetailPage extends Component {
componentDidMount() {
Expand Down Expand Up @@ -124,4 +123,6 @@ export default withRouter(connect(
RequestDetailPage,
(props) => refresh(props.params.requestId),
true,
true,
(props) => initialize(props.params.requestId),
)));

0 comments on commit bb4d68f

Please sign in to comment.