Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rest-client.fontSize Default Value is Invalid #760

Closed
SethFalco opened this issue Jan 31, 2021 · 3 comments
Closed

rest-client.fontSize Default Value is Invalid #760

SethFalco opened this issue Jan 31, 2021 · 3 comments

Comments

@SethFalco
Copy link

  • REST Client Version: 0.24.4
  • VSCode Version: 1.53.0-insider
    Version: 1.53.0-insider
    Commit: 861a88ebadb4335df92251faf6420b598440e082
    Date: 2021-01-29T21:49:47.914Z
    Electron: 11.2.1
    Chrome: 87.0.4280.141
    Node.js: 12.18.3
    V8: 8.7.220.31-electron.0
    OS: Linux x64 5.4.0-64-generic snap
  • OS Version: Ubuntu 18.04.5 LTS x86_64

Steps to Reproduce:

  1. If not configured, visit the Visual Studio Code Settings menu via the GUI.
  2. Find "Rest-client: Font Size", with the ID: rest-client.fontSize
  3. Observe the warning shown to users despite never having configured it.

image

The default configuration should not trigger any warning/error to be displayed to the user, this should instead allow for the field to be empty, or default to a value like -1 to mean the default behavior.

@ZooDoo4U
Copy link

ZooDoo4U commented Feb 6, 2021

Along with the issues for the font size, it appears upon installing the plug-in, i'm seeing an error for the font name as well.

Version: 1.53.0 (user setup)
Commit: 8490d3dde47c57ba65ec40dd192d014fd2113496
Date: 2021-02-03T20:36:38.611Z (2 days ago)
Electron: 11.2.1
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0

@Huachao
Copy link
Owner

Huachao commented Feb 9, 2021

@SethFalco @ZooDoo4U I have fixed the issue and will publish it in the next release.

@Huachao Huachao closed this as completed Feb 9, 2021
@Huachao
Copy link
Owner

Huachao commented Apr 6, 2021

@ZooDoo4U @SethFalco this has been published in the latest version 0.24.5 and you can have a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants