Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect 303 wants to use port of original request #502

Closed
pke opened this issue Jan 30, 2020 · 3 comments
Closed

Redirect 303 wants to use port of original request #502

pke opened this issue Jan 30, 2020 · 3 comments

Comments

@pke
Copy link

pke commented Jan 30, 2020

  • VSCode Version: 1.41.1
  • OS Version: Windows 8.1
  • REST Client Version: 0.23.1

Steps to Reproduce:

  1. GET http://localhost:3000
  2. This request returns 303 with a location header set to: Location: https://www.google.com/search?q=whats%2042
  3. REST client seems to resolve the google IP and tries to connect to it using the port 3000 from the initial request
    Please check your networking connectivity and your time out in 0ms according to your configuration 'rest-client.timeoutinmilliseconds'. Details: RequestError: connect ETIMEDOUT 172.217.18.4:3000.

Fix:

REST client should follow the location header verbatim without trying to resolve anything itself.

It works correctly, when no port is used in the initial request.

Huachao added a commit that referenced this issue Jan 30, 2020
@Huachao
Copy link
Owner

Huachao commented Jan 30, 2020

@pke nice catch, I will publish this fix in the next release.

@Huachao Huachao closed this as completed Jan 30, 2020
@Huachao
Copy link
Owner

Huachao commented Mar 9, 2020

@pke you can try this in the latest version 0.23.2

@pke
Copy link
Author

pke commented Mar 10, 2020

Works. Thanks for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants