Skip to content

Commit

Permalink
Upgraded to bevy 0.14.0; All tests and examples passing (#43)
Browse files Browse the repository at this point in the history
* Upgraded to bevy 0.14.0; All tests and examples passing

* Made error handling in example more clear

* Revert to simple unwrap

* Switched to git repo for crate

Git version of the crate seems to more reliably provide the steamworks SDK, which will cause strange errors at startup if not prooperly configured. Targeting the same specific tag that the version of crates.io so this shouldn't cause unecessary problems. Manual upgrades will need to be done over time. At this point I might just be willing to maintain this crate since it's so useful for publishing games on steam!

* More robust CI
  • Loading branch information
QueenOfSquiggles authored Sep 9, 2024
1 parent 88965a9 commit 939b1ea
Show file tree
Hide file tree
Showing 4 changed files with 30 additions and 19 deletions.
31 changes: 21 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,41 +1,52 @@
name: CI

on: [push, pull_request]
on: [push, pull_request, workflow_dispatch]

env:
CARGO_TERM_COLOR: always

jobs:
build:
strategy:
fail-fast: false
matrix:
os: [windows-latest, ubuntu-latest, macos-latest]
toolchain: [stable]
toolchain: [stable, nightly]
op: [build, test, clippy]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v2

- uses: dtolnay/rust-toolchain@stable
- uses: actions-rs/toolchain@v1
id: toolchain
with:
toolchain: ${{ matrix.toolchain }}
profile: minimal
components: rustfmt, clippy
override: true

- name: Install alsa and udev
run: sudo apt-get update; sudo apt-get install --no-install-recommends libasound2-dev libudev-dev
if: runner.os == 'linux'

- name: Setup cache
uses: actions/cache@v4
uses: actions/cache@v2
with:
path: |
~/.cargo/registry
~/.cargo/git
target
key: ${{ runner.os }}-test-rustc-${{ steps.toolchain.outputs.rustc_hash }}-${{ hashFiles('**/Cargo.lock') }}

- run: cargo fmt --all -- --check
if: runner.os == 'linux'

- run: cargo clippy --all-features
- uses: actions-rs/cargo@v1
if: runner.os == 'linux'
with:
command: fmt
args: --all -- --check

- run: cargo test --workspace
- uses: actions-rs/cargo@v1
with:
command: ${{ matrix.op }}
env:
CARGO_INCREMENTAL: 0
RUSTFLAGS: "-C debuginfo=0"
12 changes: 6 additions & 6 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ default = []
serde = ["steamworks/serde"]

[dependencies]
bevy_log = "0.13"
bevy_app = "0.13"
bevy_ecs = "0.13"
bevy_utils = "0.13"
steamworks = "0.11"
bevy_log = "0.14"
bevy_app = "0.14"
bevy_ecs = "0.14"
bevy_utils = "0.14"
steamworks = { git = "https://github.com/Noxime/steamworks-rs.git", tag="v0.11.0"}

[dev-dependencies]
bevy = "0.13"
bevy = "0.14"
2 changes: 1 addition & 1 deletion examples/basic.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ fn main() {
.add_plugins(SteamworksPlugin::init_app(480).unwrap())
.add_plugins(DefaultPlugins)
.add_systems(Startup, steam_system)
.run()
.run();
}
4 changes: 2 additions & 2 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
//! // it is important to add the plugin before `RenderPlugin` that comes with `DefaultPlugins`
//! .add_plugins(SteamworksPlugin::init_app(480).unwrap())
//! .add_plugins(DefaultPlugins)
//! .run()
//! .run();
//! }
//! ```
//!
Expand Down Expand Up @@ -52,7 +52,7 @@
//! .add_plugins(SteamworksPlugin::init_app(480).unwrap())
//! .add_plugins(DefaultPlugins)
//! .add_systems(Startup, steam_system)
//! .run()
//! .run();
//! }
//! ```

Expand Down

0 comments on commit 939b1ea

Please sign in to comment.