Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compliance check result export and other improvements #571

Merged

Conversation

HotCakeX
Copy link
Owner

  • You can now export the results of compliance check in the GUI using a new button that was added.

  • Improved Username detection, making it more resilient.

  • Further improved the GUI and code behinds to be more consistent.

  • Improved the comments in the code to be more accurate.

You can now export the results of compliance check in the GUI using a new button that was added.

Improved Username detection, making it more resilient.

Further improved the GUI and code behinds to be more consistent.
@HotCakeX HotCakeX added the Enhancement 💯 New feature or request label Jan 27, 2025
@HotCakeX HotCakeX self-assigned this Jan 27, 2025
@Copilot Copilot bot review requested due to automatic review settings January 27, 2025 10:54
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 10 out of 24 changed files in this pull request and generated 3 comments.

Files not reviewed (14)
  • Harden-Windows-Security Module/Main files/Core/Confirm-SystemCompliance.psm1: Language not supported
  • Harden-Windows-Security Module/Main files/C#/Others/WinIdentityUser.cs: Evaluated as low risk
  • Harden-Windows-Security Module/Main files/C#/CimInstances/BitLocker-Enable.cs: Evaluated as low risk
  • Harden-Windows-Security Module/Main files/C#/Unprotect Methods/UnprotectWindowsSecurity.cs: Evaluated as low risk
  • Harden-Windows-Security Module/Main files/C#/Others/ConfirmSystemComplianceMethods.cs: Evaluated as low risk
  • Harden-Windows-Security Module/Main files/C#/Protect Methods/DownloadsDefenseMeasures.cs: Evaluated as low risk
  • Harden-Windows-Security Module/Main files/C#/Protect Methods/MiscellaneousConfigurations.cs: Evaluated as low risk
  • Harden-Windows-Security Module/Main files/C#/Others/ControlledFolderAccessHandler.cs: Evaluated as low risk
  • Harden-Windows-Security Module/Main files/C#/Others/GetOneDriveDirectories.cs: Evaluated as low risk
  • Harden-Windows-Security Module/Main files/C#/GUI/BitLocker/Variables.cs: Evaluated as low risk
  • Harden-Windows-Security Module/Main files/C#/Protect Methods/BitLockerSettings.cs: Evaluated as low risk
  • Harden-Windows-Security Module/Main files/C#/Others/ExportSecurityPolicy.cs: Evaluated as low risk
  • Harden-Windows-Security Module/Main files/C#/GUI/Log/View.cs: Evaluated as low risk
  • Harden-Windows-Security Module/Main files/C#/GUI/Protection/View.cs: Evaluated as low risk
Comments suppressed due to low confidence (3)

Harden-Windows-Security Module/Main files/C#/Others/GitHubDesktopFinder.cs:39

  • The use of 'is' for comparison is not idiomatic C#. It should be 'if (fileList.Count == 0)'.
if (fileList.Count is 0)

Harden-Windows-Security Module/Main files/C#/Others/GitHubDesktopFinder.cs:12

  • [nitpick] The comment should be more descriptive to provide better context.
// This method searches for .exe files in the specified path and returns a list of FileInfo objects

Harden-Windows-Security Module/Main files/C#/Others/GitExesFinder.cs:13

  • The method should return a non-nullable list since it always returns a list, even if it's empty. Change the return type to List.
internal static List<FileInfo>? Find()

Added error handling around result export
@HotCakeX HotCakeX merged commit 07dad4d into main Jan 27, 2025
4 checks passed
@HotCakeX HotCakeX deleted the Added-compliance-check-result-export-and-other-improvements branch January 27, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 💯 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant